From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 21/23] twl4030-core: portability updates
Date: Mon, 29 Sep 2008 17:31:46 -0700 [thread overview]
Message-ID: <200809291731.46901.david-b@pacbell.net> (raw)
In-Reply-To: <1222707783-18936-22-git-send-email-me@felipebalbi.com>
Similar fix needs merging into patch 21 too.
--- beagle.orig/drivers/i2c/chips/twl4030-core.c 2008-09-29 17:21:37.000000000 -0700
+++ beagle/drivers/i2c/chips/twl4030-core.c 2008-09-29 17:21:25.000000000 -0700
@@ -75,6 +75,19 @@
#define twl_has_usb() false
#endif
+static inline void activate_irq(int irq)
+{
+#ifdef CONFIG_ARM
+ /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
+ * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
+ */
+ set_irq_flags(irq, IRQF_VALID);
+#else
+ /* same effect on other architectures */
+ set_irq_noprobe(irq);
+#endif
+}
+
/* Primary Interrupt Handler on TWL4030 Registers */
/* Register Definitions */
@@ -1052,9 +1065,9 @@ static void twl_init_irq(int irq_num, un
/* install an irq handler for each of the PIH modules */
for (i = irq_base; i < irq_end; i++) {
- set_irq_noprobe(i);
set_irq_chip_and_handler(i, &twl4030_irq_chip,
do_twl4030_module_irq);
+ activate_irq(i);
}
/* install an irq handler to demultiplex the TWL4030 interrupt */
next prev parent reply other threads:[~2008-09-30 0:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1222707783-18936-1-git-send-email-me@felipebalbi.com>
[not found] ` <1222707783-18936-12-git-send-email-me@felipebalbi.com>
[not found] ` <1222707783-18936-13-git-send-email-me@felipebalbi.com>
2008-09-29 20:06 ` [PATCH 12/23] move twl4030-gpio to drivers/gpio David Brownell
2008-09-29 20:19 ` Felipe Balbi
2008-09-29 20:45 ` David Brownell
2008-09-29 21:01 ` Felipe Balbi
[not found] ` <1222707783-18936-20-git-send-email-me@felipebalbi.com>
[not found] ` <1222707783-18936-21-git-send-email-me@felipebalbi.com>
2008-09-30 0:06 ` [PATCH 20/23] twl4030-gpio: irq and other cleanup David Brownell
2008-09-30 0:30 ` David Brownell
2008-09-30 0:39 ` Felipe Balbi
2008-09-30 2:36 ` David Brownell
[not found] ` <1222707783-18936-22-git-send-email-me@felipebalbi.com>
2008-09-30 0:31 ` David Brownell [this message]
2008-09-30 10:05 [PATCH 00/23] twl4030 patches (v4) Felipe Balbi
2008-09-30 10:05 ` [PATCH 01/23] twl4030: fix potential null pointer dereference Felipe Balbi
2008-09-30 10:05 ` [PATCH 02/23] twl4030-gpio: Remove default pullup enable/disable of GPIO Felipe Balbi
2008-09-30 10:05 ` [PATCH 03/23] i2c: clean add_children a bit Felipe Balbi
2008-09-30 10:05 ` [PATCH 04/23] i2c: move twl4030_keypad to new style registration Felipe Balbi
2008-09-30 10:05 ` [PATCH 05/23] i2c: move twl4030-usb to platform_device Felipe Balbi
2008-09-30 10:05 ` [PATCH 06/23] i2c: twl4030-usb: add 'vbus' sysfs file Felipe Balbi
2008-09-30 10:05 ` [PATCH 07/23] twl4030 gpio platform data Felipe Balbi
2008-09-30 10:05 ` [PATCH 08/23] twl4030 uses gpiolib Felipe Balbi
2008-09-30 10:05 ` [PATCH 09/23] i2c: move twl4030-madc to new registration style Felipe Balbi
2008-09-30 10:05 ` [PATCH 10/23] minor twl4030-core cleanups Felipe Balbi
2008-09-30 10:05 ` [PATCH 11/23] provide detailed diagnostics in add_children() Felipe Balbi
2008-09-30 10:05 ` [PATCH 12/23] move twl4030-gpio to drivers/gpio Felipe Balbi
2008-09-30 10:05 ` [PATCH 13/23] i2c: added a few missing gotos to add_children() Felipe Balbi
2008-09-30 10:05 ` [PATCH 14/23] minor irq-related cleanups Felipe Balbi
2008-09-30 10:05 ` [PATCH 15/23] i2c: switch twl4030-usb to use a resource for irq Felipe Balbi
2008-09-30 10:05 ` [PATCH 16/23] Move I2C driver model init earlier in the boot sequence Felipe Balbi
2008-09-30 10:05 ` [PATCH 17/23] i2c: minor cleanups to twl4030-pwrbutton.c Felipe Balbi
2008-09-30 10:05 ` [PATCH 18/23] twl4030-gpio irq_chip.set_type Felipe Balbi
2008-09-30 10:05 ` [PATCH 19/23] twl4030-gpio: remove legacy irq triggering calls and user Felipe Balbi
2008-09-30 10:05 ` [PATCH 20/23] twl4030-gpio: irq and other cleanup Felipe Balbi
2008-09-30 10:05 ` [PATCH 21/23] twl4030-core: portability updates Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809291731.46901.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.