From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] markers: let marker_debug as module parameter
Date: Mon, 29 Sep 2008 23:41:37 -0400 [thread overview]
Message-ID: <20080930034137.GB12733@Krystal> (raw)
In-Reply-To: <48E19CE8.8070006@cn.fujitsu.com>
* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
>
> if we want to enable marker debug output, we have to modify
> the code and remake/reinstall the kernel in current code.
>
> this patch enable marker_debug to be set when kernel start.
>
Given it's only called at probe registration/unregistration and never
put in the critical path of an executed marker, it makes sense to make
this a kernel arg debug option. I like this patch :)
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/marker.c b/kernel/marker.c
> index 9f76c4a..5d8404f 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -28,8 +28,9 @@
> extern struct marker __start___markers[];
> extern struct marker __stop___markers[];
>
> -/* Set to 1 to enable marker debug output */
> -static const int marker_debug;
> +static int marker_debug;
> +module_param(marker_debug, bool, 0);
> +MODULE_PARM_DESC(marker_debug, "Set to 1 to enable marker debug output");
>
> /*
> * markers_mutex nests inside module_mutex. Markers mutex protects the builtin
>
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2008-09-30 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 3:28 [PATCH] markers: let marker_debug as module parameter Lai Jiangshan
2008-09-30 3:41 ` Mathieu Desnoyers [this message]
2008-09-30 7:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930034137.GB12733@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.