Re: [PATCH] ASoC: Fix cs4270 error path

[Jean Delvare <khali@linux-fr.org>]

Hi Takashi,

On Tue, 30 Sep 2008 10:53:20 +0200, Takashi Iwai wrote:
> At Tue, 30 Sep 2008 10:31:37 +0200,
> Jean Delvare wrote:
> > I fear there's some confusion there. There are two different patches
> > fixing error paths in cs4270. One fixing a fallout from the new-style
> > i2c driver conversion (in cs4270_i2c_probe), under name "ASoC: Fix
> > another cs4270 error path". This one you pushed to Linus last night.
> > 
> > But there's another one, named "ASoC: Fix cs4270 error path",
> > originally posted by myself on August 31st, fixing the error path of
> > cs4270_probe. This is the one Timur was just acking, but I do _not_ see
> > it in your queue, so I suspect you missed it. I can resend it if it
> > helps.
> 
> Oh, OK, then I must have missed that.  Could you repost?

Will do in a minute.

> And, this *must* go to 2.6.27, or not?

It could go in 2.6.27, certainly, but I wouldn't say it *must* go
there. The patch is "only" fixing an error path, which by definition
isn't supposed to be needed unless something unexpected happens, in
which case the driver probably won't work anyway. So it doesn't deserve
delaying 2.6.27, and sending a pull request to Linus for just that
patch would probably be overkill. But if you get the opportunity to
send such a pull request for another problem, then it makes sense to
include this cs4270 fix as well.

Anyway it's really up to you and Timur. I just happened to notice the
bug and posted a fix, but I'm not even using the driver myself.

> Frankly, this series of cs4270 patches have been hard to handle
> because it was always unclear what the patch is for.
> The description "It's for 2.6.x" is too ambiguous because it doesn't
> always mean the purpose but also can mean the based version of the
> patch.  So, a more clear sign would be really helpful for me at the
> next time...

OK, sorry about that. I'll try to make things clearer next time.

-- 
Jean Delvare