From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] mpc52xx_psc_spi setting the tdfOnExit flag only on the last byte Date: Tue, 30 Sep 2008 08:07:26 -0600 Message-ID: <20080930140726.GG18313@secretlab.ca> References: <1222766572-17499-1-git-send-email-sbabic@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Stefano Babic Return-path: Content-Disposition: inline In-Reply-To: <1222766572-17499-1-git-send-email-sbabic-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Sep 30, 2008 at 11:22:51AM +0200, Stefano Babic wrote: > According to the manual the "tdfOnExit" flag must be set on the last byte > we want to send. The PSC controller holds SS low until the flag is set. > However, the flag was set always on the last byte of the FIFO, independently if > it is the last byte of the transfer. This generates spurious toggling of the > SS signals that breaks the protocol of some peripherals. > > Signed-off-by: Stefano Babic Your patchs and descriptions are getting sent in separate emails. How are you sending your patches? g. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/