From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH 3/5] [RFC] ALSA ASOC Adds DSP DAI format support for platform driver Date: Tue, 30 Sep 2008 16:11:38 +0300 Message-ID: <20080930161138.41de23b3.jarkko.nikula@nokia.com> References: <20080929141540.e6ae8ead.jarkko.nikula@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.nokia.com ([192.100.122.233]:30622 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbYI3NMc (ORCPT ); Tue, 30 Sep 2008 09:12:32 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Arun KS Cc: "linux-omap@vger.kernel.org List" , alsa-devel@vger.kernel.org, felipe.balbi@nokia.com On Tue, 30 Sep 2008 12:11:45 +0530 "ext Arun KS" wrote: > > I think this is not enough. The word clock length equals to one BCLK > > cycle in DSP mode. Not n channel bit BCLK cycles like in I2S. > > > > In DSP Mode, Frame sync is followed by two data words. > I tested this patch and its working. Am i missing something ? > I meant length of FS/LRC[IN | OUT] signal itself. E.g. see figures 3-7 and 3-8 in AIC23 data manual: http://www.ti.com/lit/gpn/tlv320aic23 Now omap-mcbsp.c sets this FS length to 16 BCLK periods in omap_mcbsp_dai_hw_params. Currently code is pretty much tailored for 16-bit stereo I2S so probably some McBSP configuration bits are better set in another function than currently :-) Jarkko