From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>
Subject: Re: [patch 1/2] x86: track memtype for RAM in page struct - v3
Date: Tue, 30 Sep 2008 17:28:01 +1000 [thread overview]
Message-ID: <200809301728.02269.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080924155332.GA29041@linux-os.sc.intel.com>
On Thursday 25 September 2008 01:53, Venki Pallipadi wrote:
> /*
> + * RED-PEN: TODO: Add PageReserved() check as well here,
> + * once we add SetPageReserved() to all the drivers using
> + * set_memory_* or set_pages_*.
> + *
> + * This will help prevent accidentally freeing pages
> + * before setting the attribute back to WB.
> + */
I'd rather we didn't add any more uses of PageReserved without a
really good reason.
At this point in time (or at least last time I looked, a year or
two ago), it isn't a whole lot of work to remove PG_reserved
completely. If the waters get muddied up again, it could require
another significant rework to remove it in future...
Thanks,
Nick
next prev parent reply other threads:[~2008-09-30 7:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 0:00 [patch 0/2] PAT fix/optimization Venkatesh Pallipadi
2008-09-13 0:00 ` [patch 1/2] x86: track memtype for RAM in page struct Venkatesh Pallipadi
2008-09-13 17:03 ` Jeremy Fitzhardinge
2008-09-14 13:29 ` Ingo Molnar
2008-09-14 14:18 ` Jeremy Fitzhardinge
2008-09-14 14:22 ` Ingo Molnar
2008-09-23 21:46 ` Venki Pallipadi
2008-09-23 21:59 ` Christoph Lameter
2008-09-24 15:53 ` [patch 1/2] x86: track memtype for RAM in page struct - v3 Venki Pallipadi
2008-09-27 17:59 ` Ingo Molnar
2008-09-30 7:28 ` Nick Piggin [this message]
2008-09-30 11:21 ` Ingo Molnar
2008-09-30 21:14 ` Suresh Siddha
2008-10-01 9:29 ` Ingo Molnar
2008-10-02 2:27 ` Nick Piggin
2008-09-13 17:24 ` [patch 1/2] x86: track memtype for RAM in page struct Frans Pop
2008-09-14 14:12 ` Ingo Molnar
2008-09-23 21:48 ` Pallipadi, Venkatesh
2008-09-13 0:00 ` [patch 2/2] x86: Handle error returns in set_memory_* Venkatesh Pallipadi
2008-09-14 13:27 ` Ingo Molnar
2008-09-14 14:35 ` Frans Pop
2008-09-14 14:10 ` Ingo Molnar
2008-09-30 8:36 ` Frans Pop
2008-09-30 21:29 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809301728.02269.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=cl@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.