From: Jens Axboe <jens.axboe@oracle.com>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Block: Fix blk_start_queueing() so as not to process a stopped queue
Date: Wed, 1 Oct 2008 09:48:43 +0200 [thread overview]
Message-ID: <20081001074843.GA19428@kernel.dk> (raw)
In-Reply-To: <87wsgtb4t6.fsf@denkblock.local>
On Wed, Oct 01 2008, Elias Oltmanns wrote:
> Especially since blk_start_queueing() is used as the unplug_fn() callback
> by the cfq scheduler, we'd better make it behave like a proper unplug
> function. That is to say, return immediately if the queue is stopped.
>
> Cc: stable <stable@kernel.org>
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
> ---
> This is not a recent regression, so it might not be accepted as an rc
> fix. However, it most definitely is a bug and should go into a stable
> release. Applies to 2.6.27-rc8.
I don't think this is by far serious enough for -stable. Please let me
know what bad behaviour you observed due to this bug?
--
Jens Axboe
next prev parent reply other threads:[~2008-10-01 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:19 Block: Fix blk_start_queueing() so as not to process a stopped queue Elias Oltmanns
2008-10-01 7:48 ` Jens Axboe [this message]
2008-10-02 15:55 ` Elias Oltmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001074843.GA19428@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=eo@nebensachen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.