From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Grant Grundler <grundler@parisc-linux.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci: introduce users of ioremap_pcibar()
Date: Wed, 1 Oct 2008 12:33:38 +0200 [thread overview]
Message-ID: <200810011233.45495.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20080930153001.1107c0de@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
Arjan van de Ven wrote:
> On Tue, 30 Sep 2008 23:24:50 -0600
>
> Grant Grundler <grundler@parisc-linux.org> wrote:
> > > And pci_iomap() takes more parameters than most driver writers want
> > > or need. Most of the time it's "I want the whole bar"; even if my
> > > patch wraps around that, making the API simpler is still worth it
> > > imo
> >
> > You are right about that.
> > Would calling the API "pci_iomap_bar()" to keep the naming consistent
> > help make it more acceptable?
>
> I'm fine with pci_iomap_bar()... it meets my goals
> Would be nice if I'd be allowed to make it only work on MEM bars not IO
> bars (so that drivers don't accidentally end up calling this on an IO
> bar and then using readl() etc)
IIRC pci_iomap() was documented to work on both at it does "the right thing"
automatically.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-10-01 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 23:36 [PATCH] pci: introduce an ioremap_pcibar(pdev, barnr) function Arjan van de Ven
2008-09-26 23:37 ` [PATCH] pci: introduce users of ioremap_pcibar() Arjan van de Ven
2008-09-29 7:26 ` Grant Grundler
2008-09-29 9:20 ` Alan Cox
2008-09-29 13:42 ` Arjan van de Ven
2008-09-29 17:10 ` Grant Grundler
2008-09-29 17:23 ` Arjan van de Ven
2008-10-01 5:24 ` Grant Grundler
2008-09-30 22:30 ` Arjan van de Ven
2008-10-01 10:33 ` Rolf Eike Beer [this message]
2008-10-01 12:42 ` Kyle McMartin
2008-10-01 12:57 ` Matthew Wilcox
2008-10-01 13:07 ` Kyle McMartin
2008-10-01 13:53 ` Arjan van de Ven
2008-09-27 2:56 ` [PATCH] pci: introduce an ioremap_pcibar(pdev, barnr) function Matthew Wilcox
2008-09-27 15:35 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2008-09-29 18:08 [PATCH] pci: introduce users of ioremap_pcibar() Marin Mitov
2008-10-01 6:39 Marin Mitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810011233.45495.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=arjan@infradead.org \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.