All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org,
	Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
Date: Wed, 1 Oct 2008 13:22:48 +0200	[thread overview]
Message-ID: <20081001132248.191e92b3@hyperion.delvare> (raw)
In-Reply-To: <20080930124424.GA6878@oksana.dev.rtsoft.ru>

Hi Anton,

On Tue, 30 Sep 2008 16:44:24 +0400, Anton Vorontsov wrote:
> On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote:
> > of/base.c matches on the first (most specific) entries, which isn't
> > quite practical but it was discussed[1] that this won't change.
> > 
> > The bindings specifies verbose information for the devices, but
> > it doesn't fit in the I2C ID's 20 characters limit. The limit won't
> > change[2], and the bindings won't change either as they're correct.
> > 
> > So we have to put an exception for the MPC8349E-mITX-compatible
> > MCUs.
> > 
> > [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html
> > [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
> >  drivers/of/base.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Any issues with this or the second patch? Can we merge them?

I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.

-- 
Jean Delvare

  reply	other threads:[~2008-10-01 11:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 14:12 [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list Anton Vorontsov
2008-09-30 12:44 ` Anton Vorontsov
2008-10-01 11:22   ` Jean Delvare [this message]
2008-10-01 11:39     ` Anton Vorontsov
2008-10-06 17:28       ` Anton Vorontsov
     [not found]         ` <20081006172831.GA27233-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-10-06 17:31           ` [PATCH 1/2] OF: add fsl, mcu-mpc8349emitx " Grant Likely
2008-10-06 17:31             ` [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx " Grant Likely
2008-10-06 18:44             ` Anton Vorontsov
2008-10-10 14:18 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081001132248.191e92b3@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=ben-linux@fluff.org \
    --cc=i2c@lm-sensors.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.