Re: [Qemu-devel] [PATCH] Reset CPU on INIT IPI

[Aurelien Jarno <aurelien@aurel32.net>]

On Thu, Sep 25, 2008 at 02:31:53PM +0300, Gleb Natapov wrote:
> INIT IPI should reset CPU. Also non boot CPU should be halted. It will
> be un-halted by SIPI.

Applied, thanks.

> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> 
> diff --git a/hw/apic.c b/hw/apic.c
> index 64e75ad..1a44c3a 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -458,6 +458,11 @@ static void apic_init_ipi(APICState *s)
>      s->initial_count = 0;
>      s->initial_count_load_time = 0;
>      s->next_time = 0;
> +
> +    cpu_reset(s->cpu_env);
> +
> +    if (!(s->apicbase & MSR_IA32_APICBASE_BSP))
> +        s->cpu_env->halted = 1;
>  }
>  
>  /* send a SIPI message to the CPU to start it */
> --
> 			Gleb.
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net