From: Jens Axboe <jens.axboe@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: John Jolly <jjolly@novell.com>,
JBlunck@novell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h
Date: Thu, 2 Oct 2008 08:38:58 +0200 [thread overview]
Message-ID: <20081002063858.GS19428@kernel.dk> (raw)
In-Reply-To: <20081001231138.266452cc.akpm@linux-foundation.org>
On Wed, Oct 01 2008, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <jjolly@novell.com> wrote:
> > From: John Jolly <jjolly@novell.com>
> >
> > Added line to install include/linux/blktrace_api.h during 'make headers_install'
> >
> > Signed-off-by: John Jolly <jjolly@novell.com>
> > CC: Jan Blunck <JBlunck@novell.com>
> > ---
> > include/linux/Kbuild | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> > index b68ec09..f1e5fa1 100644
> > --- a/include/linux/Kbuild
> > +++ b/include/linux/Kbuild
> > @@ -41,6 +41,7 @@ header-y += baycom.h
> > header-y += bfs_fs.h
> > header-y += blkpg.h
> > header-y += bpqether.h
> > +header-y += blktrace_api.h
> > header-y += can.h
> > header-y += cdk.h
> > header-y += chio.h
>
> The two basic and almost always necessary parts of a patch changelog are
>
> a) what was changed and
>
> b) why the change was made
>
> Your changelog had no b), hence nobody is likely to apply the patch.
A similar patch is already merged for 2.6.28 as well.
--
Jens Axboe
next prev parent reply other threads:[~2008-10-02 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 14:47 [PATCH 1/1] block: installing include/linux/blktrace_api.h John Jolly
2008-10-02 6:11 ` Andrew Morton
2008-10-02 6:38 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-24 14:42 John Jolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002063858.GS19428@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=JBlunck@novell.com \
--cc=akpm@linux-foundation.org \
--cc=jjolly@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.