From: Mark Brown <broonie@sirena.org.uk>
To: Arun KS <arunks@mistralsolutions.com>
Cc: alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>,
Jarkko Nikula <jarkko.nikula@nokia.com>,
felipe.balbi@nokia.com, troy.kisky@boundarydevices.com
Subject: Re: [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver
Date: Thu, 2 Oct 2008 11:15:28 +0100 [thread overview]
Message-ID: <20081002101524.GF2848@sirena.org.uk> (raw)
In-Reply-To: <dfeb90390810020225h2e5e33a5jc4b71816bda0c21e@mail.gmail.com>
On Thu, Oct 02, 2008 at 02:55:27PM +0530, Arun KS wrote:
> ASoC codec driver for TLV320AIC23 device
> Signed-off-by: Arun KS <arunks@mistralsolutions.com>
This looks good and it's probably as well to merge it now since the one
issue below is mostly cosmetic so if nothing else it'll be easier to
review incrementally so:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> +static const char *deemph_text[] = {"None", "32Khz", "44.1Khz", "48Khz"};
> +static const char *sidetone_text[] = {"-6db", "-9db", "-12db", "-18db", "0db"};
...
> +static const struct soc_enum tlv320aic23_sidetone =
> + SOC_ENUM_SINGLE(TLV320AIC23_ANLG, 6, 5, sidetone_text);
...
> + SOC_ENUM("Sidetone Gain", tlv320aic23_sidetone),
As I said on the last submission this should really be a SOC_SINGLE_TLV
called "Sidetone Volume" rather than an enumeration - it's a dB scale
controlling gain rather than an enumeration.
next prev parent reply other threads:[~2008-10-02 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 9:25 [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver Arun KS
2008-10-02 10:15 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-02 9:15 Arun KS
2008-10-03 8:18 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002101524.GF2848@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=arunks@mistralsolutions.com \
--cc=felipe.balbi@nokia.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.