From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Vincent Legoll" <vincent.legoll@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH] PCI probing debug message uniformization
Date: Thu, 2 Oct 2008 11:46:28 -0700 [thread overview]
Message-ID: <200810021146.28704.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <4727185d0809291403w38422338p3ffe2a1c27c39939@mail.gmail.com>
On Monday, September 29, 2008 2:03 pm Vincent Legoll wrote:
> Hello,
>
> Here is a patch to uniformize PCI probing debug messages at
> boot with dev_printk() intead of manual printk()
>
> for example, it goes from the mixed-style:
>
> PCI: 0000:00:1b.0 reg 10 64bit mmio: [f4280000, f4283fff]
> pci 0000:00:1b.0: PME# supported from D0 D3hot D3cold
>
> to uniform:
>
> pci 0000:00:1b.0: reg 10 64bit mmio: [f4280000, f4283fff]
> pci 0000:00:1b.0: PME# supported from D0 D3hot D3cold
>
> If people prefer the UPPERCASE "PCI:" prefix from dev_printk(),
> that would be matter for another patch...
>
> I'm currently running the kernel with that patch applied, and
> diffed bootlog, everything looks OK
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Bjorn, how does this jive with the various other debug harmonization patches
you've been putting together & reviewing?
Thanks,
Jesse
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2008-10-02 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 21:03 [PATCH] PCI probing debug message uniformization Vincent Legoll
2008-10-02 18:46 ` Jesse Barnes [this message]
2008-10-02 18:59 ` Bjorn Helgaas
2008-10-03 9:14 ` Vincent Legoll
2008-10-03 18:13 ` Vincent Legoll
2008-10-03 18:57 ` Bjorn Helgaas
2008-10-03 22:50 ` Vincent Legoll
2008-10-10 16:07 ` Jesse Barnes
2008-10-12 10:26 ` Vincent Legoll
2008-10-15 10:49 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810021146.28704.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.