From: Andrew Morton <akpm@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Improve buffered streaming write ordering
Date: Thu, 2 Oct 2008 12:44:33 -0700 [thread overview]
Message-ID: <20081002124433.f6612036.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081002181856.GB29613@skywalker>
On Thu, 2 Oct 2008 23:48:56 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> >
> > For a 4.5GB streaming buffered write, this printk inside
> > ext4_da_writepage shows up 37,2429 times in /var/log/messages.
> >
>
> Part of that can happen due to shrink_page_list -> pageout -> writepagee
> call back with lots of unallocated buffer_heads(blocks).
That workload shouldn't be using that code path much at all. It's
supposed to be the case that pdflush and balance_dirty_pages() do most
of the writeback work.
And that _used_ to be the case, but we broke it. It happened several
years ago and I wasn't able to provoke anyone into finding out why.
iirc the XFS guys noticed it because their throughput was fairly badly
affected.
next prev parent reply other threads:[~2008-10-02 19:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 18:40 [PATCH] Improve buffered streaming write ordering Chris Mason
2008-10-02 4:52 ` Andrew Morton
2008-10-02 12:20 ` Chris Mason
2008-10-02 16:12 ` Chris Mason
2008-10-02 18:18 ` Aneesh Kumar K.V
2008-10-02 19:44 ` Andrew Morton [this message]
2008-10-02 23:43 ` Dave Chinner
2008-10-03 19:45 ` Chris Mason
2008-10-06 10:16 ` Aneesh Kumar K.V
2008-10-06 14:21 ` Chris Mason
2008-10-07 8:45 ` Aneesh Kumar K.V
2008-10-07 9:05 ` Christoph Hellwig
2008-10-07 10:02 ` Aneesh Kumar K.V
2008-10-07 13:29 ` Theodore Tso
2008-10-07 13:36 ` Christoph Hellwig
2008-10-07 13:36 ` Christoph Hellwig
2008-10-07 13:36 ` Christoph Hellwig
2008-10-07 14:46 ` Nick Piggin
2008-10-07 13:55 ` Peter Staubach
2008-10-07 14:38 ` Chuck Lever
2008-10-09 15:11 ` Chris Mason
2008-10-10 5:13 ` Dave Chinner
2008-10-03 1:11 ` Chris Mason
2008-10-03 2:43 ` Nick Piggin
2008-10-03 12:07 ` Chris Mason
2008-10-02 18:08 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002124433.f6612036.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=chris.mason@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.