All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: qemu-devel@nongnu.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	michael@free-electrons.com
Subject: [Qemu-devel] [patch 3/4] Improve pflash cfi01 debug messages
Date: Thu, 02 Oct 2008 15:02:17 +0200	[thread overview]
Message-ID: <20081002130239.545819607@free-electrons.com> (raw)
In-Reply-To: 20081002130214.299833919@free-electrons.com

[-- Attachment #1: pflash-cfi01-improve-debug-msgs --]
[-- Type: text/plain, Size: 1239 bytes --]

This patches slightly improves the debugging messages in pflash_read()
and pflash_write().

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 hw/pflash_cfi01.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: qemu/hw/pflash_cfi01.c
===================================================================
--- qemu.orig/hw/pflash_cfi01.c
+++ qemu/hw/pflash_cfi01.c
@@ -111,8 +111,8 @@
     else if (pfl->width == 4)
         boff = boff >> 2;
 
-    DPRINTF("%s: reading offset " TARGET_FMT_lx " under cmd %02x\n",
-            __func__, boff, pfl->cmd);
+    DPRINTF("%s: reading offset " TARGET_FMT_lx " under cmd %02x width %d\n",
+            __func__, offset, pfl->cmd, width);
 
     switch (pfl->cmd) {
     case 0x00:
@@ -205,7 +205,7 @@
     cmd = value;
     offset -= pfl->base;
 
-    DPRINTF("%s: offset " TARGET_FMT_lx " %08x %d wcycle 0x%x\n",
+    DPRINTF("%s: writing offset " TARGET_FMT_lx " value %08x width %d wcycle 0x%x\n",
             __func__, offset, value, width, pfl->wcycle);
 
     /* Set the device in I/O access mode */

-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2008-10-02 13:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 13:02 [Qemu-devel] [patch 0/4] [RFC] Add flash emulation to the Versatile PB platform Thomas Petazzoni
2008-10-02 13:02 ` [Qemu-devel] [patch 1/4] Increase write buffer size in pflash emulation Thomas Petazzoni
2008-10-03 23:05   ` andrzej zaborowski
2008-10-06  9:47     ` Thomas Petazzoni
2008-10-02 13:02 ` [Qemu-devel] [patch 2/4] Reset wcycle after erase confirm Thomas Petazzoni
2008-10-02 13:02 ` Thomas Petazzoni [this message]
2008-10-02 13:02 ` [Qemu-devel] [patch 4/4] Add Flash support to the Versatile PB platform Thomas Petazzoni
2008-10-02 16:33   ` Paul Brook
2008-10-02 17:00     ` Thomas Petazzoni
2008-10-03 13:44     ` Thomas Petazzoni
2008-10-03 14:37       ` Thomas Petazzoni
2008-10-06  9:48         ` Thomas Petazzoni
2008-10-02 18:25   ` andrzej zaborowski
2008-10-03  7:55     ` Thomas Petazzoni
2008-10-06 17:23 ` [Qemu-devel] [Patch 0/4] [RFC] Zero Cluster Dedup, Offline dedup, qemu-img extentions Shahar Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081002130239.545819607@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=michael@free-electrons.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.