Re: [Qemu-devel] [PATCH] Fix symbol lookup for mips64* targets

[Thiemo Seufer <ths@networkno.de>]

Stefan Weil wrote:
> For 64 bit targets, lookup_symbol() compares a 64-bit target address
> with a 32 bit symbol address. This only works for addresses less than 2^32.
> 
> MIPS64 kernels use addresses larger than 0xffffffff80000000,
> so qemu.log never shows symbolic names.
> 
> My patch is a workaround which works with Qemu's 32 bit address hack.
> Please apply it to Qemu trunk.
> 
> Maybe a better solution would use symbol addresses without shortening
> them to 32 bits.
> 
> Regards
> Stefan
> 

> Fix symbol lookup for mips64* targets.
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de> 
> 
> Index: disas.c
> ===================================================================
> --- disas.c	(Revision 5400)
> +++ disas.c	(Arbeitskopie)
> @@ -309,6 +309,11 @@
>      struct syminfo *s;
>      target_ulong addr;
>  
> +#if defined(TARGET_MIPS64)
> +    /* Adresses in syminfos are 32 bit values. */
> +    orig_addr &= 0xffffffff;

This isn't true in general, not all MIPS64 kernels use the -msym32
optimization.


Thiemo