All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH v2] OMAP3: Update USBHOST pinmux settings
Date: Thu, 2 Oct 2008 23:51:03 -0700	[thread overview]
Message-ID: <200810022351.04241.david-b@pacbell.net> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02D603E114@dbde02.ent.ti.com>

On Tuesday 30 September 2008, Gadiyar, Anand wrote:
> From: Anand Gadiyar <gadiyar@ti.com>
> 
> Add pin-mux settings for OHCI in PHY mode.
> Also change settings for EHCI in TLL mode.
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> ---
> Fixed comments below. Also fixed one pin that should
> have been marked output, but was wrongly marked input.
> 
>  arch/arm/mach-omap2/mux.c             |   67 +++++++++++++++++++++++++++-------
>  arch/arm/plat-omap/include/mach/mux.h |   26 ++++++++++++-
>  2 files changed, 80 insertions(+), 13 deletions(-)

I didn't see anything obvious to complain about, but then I've
not delved deeply into OMAP3 EHCI.

Were you the person who was looking to package the PHY/TLL
mode setup in platform data?  Any progress on that?

(I added EHCI to my Beagle/Overo config, and it came up
with all kinds of nonsense on the Beagle.  Configured
several ports, not just one, and in fact this board does
not even *have* the EHCI transceiver.  So it was very
obvious that EHCI setup wasn't right yet.  That's even
apart from the messaging goofs, which have trivial fixes
I'll send along in a while.)

- dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-10-03  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30 15:18 [PATCH v2] OMAP3: Update USBHOST pinmux settings Gadiyar, Anand
2008-10-03  6:51 ` David Brownell [this message]
2008-10-03 13:20   ` Gadiyar, Anand
2008-10-06 10:39 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810022351.04241.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=gadiyar@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.