From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arjan van de Ven Subject: Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Date: Fri, 3 Oct 2008 05:49:21 -0700 Message-ID: <20081003054921.376a41ec@infradead.org> References: <200808290002.55026.rjw@sisk.pl> <200809300010.39000.rjw@sisk.pl> <20081003013557.42ce685d.akpm@linux-foundation.org> <200810031327.19293.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from casper.infradead.org ([85.118.1.10]:34612 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbYJCMuV (ORCPT ); Fri, 3 Oct 2008 08:50:21 -0400 In-Reply-To: <200810031327.19293.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Andrew Morton , Jeff Garzik , Tejun Heo , ACPI Devel Maling List , linux-ide@vger.kernel.org, Thomas Renninger , Robert Hancock , LKML , Frans Pop , Maciej Rutecki On Fri, 3 Oct 2008 13:27:18 +0200 "Rafael J. Wysocki" wrote: > On Friday, 3 of October 2008, Andrew Morton wrote: > > On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki" > > wrote: > > > > > Hibernation: Introduce new system state for the last phase of > > > hibernation > > > > > > Replace unused SYSTEM_SUSPEND_DISK with a new system_state value > > > SYSTEM_HIBERNATE_ENTER that can be used by device drivers to > > > check if the system is in the last phase of hibernation. > > > > Violent objections. > > > > We just don't know what this change will do. It potentially affects > > every code site in the kernel which looks at system_state. > > Do you mean anyone checking 'system_state != SOMETHING' ? Oh well. I think Andrew also means things looking for system_state > something like arch/powerpc/platforms/cell/smp.c: if (system_state < SYSTEM_RUNNING && arch/powerpc/kernel/smp.c: if (system_state < SYSTEM_RUNNING) arch/powerpc/kernel/smp.c: if (system_state > SYSTEM_BOOTING) drivers/xen/xenbus/xenbus_probe.c: if (system_state > SYSTEM_RUNNING) { -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org