From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <felipe.balbi@nokia.com>, linux-omap@vger.kernel.org
Subject: Re: [patch twl 1/2] remove <linux/i2c/twl4030-rtc.h>
Date: Fri, 3 Oct 2008 07:21:56 -0700 [thread overview]
Message-ID: <200810030721.57494.david-b@pacbell.net> (raw)
In-Reply-To: <20081003132857.GM25482@atomide.com>
On Friday 03 October 2008, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [081002 12:08]:
> > On Wed, Oct 01, 2008 at 11:42:50PM -0700, David Brownell wrote:
> > > From: David Brownell <dbrownell@users.sourceforge.net>
> > >
> > > Remove <linux/i2c/twl4030-rtc.h> by moving all the relevant contents
> > > into the driver itself, and removing the rest. Stuff removed included
> > > many useless bitmasks, and remnants of the platform data hook.
> > >
> > > ....
> > >
> > > No functional changes, just shrinkage.
> > >
> > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> >
> > I was willing to get rid of all of them and just keep twl4030.h
> > Nice job Dave :-)
>
> This one does not apply, maybe some other patch is missing?
Yes; one in addition to the two you merged with the RC8 sync.
I'll repost all the as-yet-unmerged TWL related patches on
top of RC8.
- Dave
> patching file drivers/rtc/rtc-twl4030.c
> Hunk #1 FAILED at 28.
> Hunk #2 succeeded at 375 (offset 8 lines).
> Hunk #3 succeeded at 407 (offset 8 lines).
> Hunk #4 succeeded at 419 (offset 8 lines).
> Hunk #5 succeeded at 467 (offset 8 lines).
> Hunk #6 succeeded at 496 (offset 8 lines).
> Hunk #7 succeeded at 506 (offset 8 lines).
> Hunk #8 succeeded at 514 (offset 8 lines).
> 1 out of 8 hunks FAILED -- saving rejects to file
> drivers/rtc/rtc-twl4030.c.rej
> patching file include/linux/i2c/twl4030-pwrirq.h
> patching file include/linux/i2c/twl4030-rtc.h
>
> Tony
>
next prev parent reply other threads:[~2008-10-03 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 6:42 [patch twl 1/2] remove <linux/i2c/twl4030-rtc.h> David Brownell
2008-10-02 9:05 ` Felipe Balbi
2008-10-03 13:28 ` Tony Lindgren
2008-10-03 14:21 ` David Brownell [this message]
2008-10-06 14:57 ` Kevin Hilman
2008-10-06 16:39 ` David Brownell
2008-10-07 8:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810030721.57494.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.