From: Arjan van de Ven <arjan@infradead.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [regression] Latest git has WARN_ON storm with e1000e driver
Date: Fri, 3 Oct 2008 08:08:07 -0700 [thread overview]
Message-ID: <20081003080807.28349678@infradead.org> (raw)
In-Reply-To: <200810031041.49350.borntraeger@de.ibm.com>
On Fri, 3 Oct 2008 10:41:49 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> This is caused by holding a spinlock (__driver_attach) and checking
> for preempt_count (e1000_acquire_swflag_ich8lan).
>
> I suggest to revert this commit, since we cannot take a mutex while
> holding a spinlock.
> The simple solution of replacing the mutex with a spinlock does not
> work, since we call msleep on several places in the code. Replacing
> all that code doesnt look like 2.6.27 material.
hi,
could you do a run with frame pointers enabled?
that should clear up the stack noise....
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
prev parent reply other threads:[~2008-10-03 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 8:41 [regression] Latest git has WARN_ON storm with e1000e driver Christian Borntraeger
2008-10-03 14:52 ` Linus Torvalds
2008-10-03 15:20 ` Christian Borntraeger
2008-10-03 15:36 ` Linus Torvalds
2008-10-03 15:50 ` Christian Borntraeger
2008-10-03 15:55 ` Christian Borntraeger
2008-10-03 16:05 ` Linus Torvalds
2008-10-03 16:23 ` Linus Torvalds
2008-10-03 16:25 ` Brandeburg, Jesse
2008-10-03 16:36 ` Linus Torvalds
2008-10-03 19:41 ` Thomas Gleixner
2008-10-03 16:25 ` Christian Borntraeger
2008-10-03 15:08 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003080807.28349678@infradead.org \
--to=arjan@infradead.org \
--cc=borntraeger@de.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.