From: Stephen Hemminger <shemminger@vyatta.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Tino Keitel <tino.keitel@gmx.de>,
netdev@vger.kernel.org, Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] sky2: Fix recent WOL regression
Date: Fri, 3 Oct 2008 09:02:43 +0200 [thread overview]
Message-ID: <20081003090243.724cf79c@speedy> (raw)
In-Reply-To: <200810022339.34025.rjw@sisk.pl>
On Thu, 2 Oct 2008 23:39:33 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> sky2: Fix recent WOL regression
>
> Since dev->power.should_wakeup bit is used by the PCI core to
> decide whether the device should wake up the system from sleep
> states, set/unset this bit whenever WOL is enabled/disabled using
> sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> machine).
>
> Remove an open-coded reference to the standard PCI PM registers that
> is not used any more.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Reported-by: Tino Keitel <tino.keitel@gmx.de>
> ---
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Thanks for fixing this.
next prev parent reply other threads:[~2008-10-03 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 21:39 [PATCH] sky2: Fix recent WOL regression Rafael J. Wysocki
2008-10-03 7:02 ` Stephen Hemminger [this message]
2008-10-08 22:55 ` Rafael J. Wysocki
2008-10-08 22:55 ` Rafael J. Wysocki
2008-10-08 23:12 ` David Miller
2008-10-08 23:12 ` David Miller
2008-10-09 21:01 ` Rafael J. Wysocki
2008-10-09 21:01 ` Rafael J. Wysocki
2008-10-03 7:02 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2008-10-02 21:39 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003090243.724cf79c@speedy \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tino.keitel@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.