All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Petr Baudis <petr.baudis@novartis.com>
Subject: Re: [PATCH] git-gui: Implement a 'clone' subcommand
Date: Fri, 3 Oct 2008 12:17:29 +0200	[thread overview]
Message-ID: <20081003101729.GZ10360@machine.or.cz> (raw)
In-Reply-To: <20080930195330.GA4413@spearce.org>

On Tue, Sep 30, 2008 at 12:53:30PM -0700, Shawn O. Pearce wrote:
> Petr Baudis <pasky@suse.cz> wrote:
> >  Documentation/git-gui.txt         |    5 +++++
> >  git-gui/git-gui.sh                |   21 ++++++++++++++++++---
> >  git-gui/lib/choose_repository.tcl |   11 ++++++++++-
> >  3 files changed, 33 insertions(+), 4 deletions(-)
> 
> This looks fine, except for the diffstat.  You can't patch
> the docs and the code in the same patch as they are in two
> different repositories...  :-|

Oh, I forgot again, sorry. :-( But I think this shows rather bad design
of the layout, doesn't it? Shouldn't this documentation be kept in
git-gui/Documentation/{git-gui,config}.txt and included from git's
Documentation/?

> Also, I don't know if you've noticed but I think tg is
> sending duplicate "To" headers in the messages:

Thanks - I have noticed already but I didn't have time yet to fix it and
it seems generally pretty harmless. I will try to do something with that
later.

-- 
				Petr "Pasky" Baudis
People who take cold baths never have rheumatism, but they have
cold baths.

      parent reply	other threads:[~2008-10-03 10:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30 16:51 [PATCH] git-gui: Implement a 'clone' subcommand Petr Baudis
2008-09-30 19:53 ` Shawn O. Pearce
2008-09-30 19:58   ` Shawn O. Pearce
2008-10-03 10:13     ` [PATCH] git-gui: Correctly set up locators in case of preset URL variable Petr Baudis
2008-10-03 10:23       ` H.Merijn Brand
2008-10-03 10:48         ` Petr Baudis
2008-10-10 16:42       ` Shawn O. Pearce
2008-10-03 10:17   ` Petr Baudis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081003101729.GZ10360@machine.or.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=petr.baudis@novartis.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.