From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip
Date: Fri, 3 Oct 2008 13:06:53 +0530
Message-ID: <200810031306.53295.amit.shah@redhat.com>
References: <D8078B8B3B09934AA9F8F2D5FB3F28CE08A3B9C7B0@pdsmsx502.ccr.corp.intel.com> <48E4CC36.70607@redhat.com> <20081002164559.GA16709@yukikaze>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
To: Avi Kivity <avi@redhat.com>, "Yang, Sheng" <sheng.yang@intel.com>,
	"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>,
	sheng@linux.intel.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:40978 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753777AbYJCHiN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 3 Oct 2008 03:38:13 -0400
In-Reply-To: <20081002164559.GA16709@yukikaze>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

* On Thursday 02 Oct 2008 22:15:59 Sheng Yang wrote:

>  /* This should be called with the kvm->lock mutex held */
> -void kvm_set_irq(struct kvm *kvm, int irq, int level)
> +void kvm_set_irq(struct kvm *kvm, int irq, int level, int irq_source_id)

Just one thing: can you make the irq_source_id argument the 3rd one and 
the 'level' as the last one? It's clearer to think of it that way.

I'll test this next week.