From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Date: Fri, 03 Oct 2008 07:54:51 +0000 Subject: Re: [PATCH 2/8]kvm: Moving device_assignment logic to kvm_main.c Message-Id: <200810031312.52056.amit.shah@redhat.com> List-Id: References: <42DFA526FC41B1429CE7279EF83C6BDC01A53DF4@pdsmsx415.ccr.corp.intel.com> In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A53DF4@pdsmsx415.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org * On Friday 03 Oct 2008 13:02:05 Zhang, Xiantao wrote: > Amit Shah wrote: > > * On Monday 29 Sep 2008 10:56:29 Zhang, Xiantao wrote: > >> From: Xiantao Zhang > >> Date: Sat, 27 Sep 2008 10:59:36 +0800 > >> Subject: [PATCH] kvm: Moving device_assignment logic to kvm_main.c > >> > >> To share with other archs, this patch moves device_assignment > >> logic to common parts. > >> Signed-off-by: Xiantao Zhang > >> > >> diff --git a/include/linux/kvm.h b/include/linux/kvm.h > >> index 4269be1..9acf34a 100644 > >> --- a/include/linux/kvm.h > >> +++ b/include/linux/kvm.h > >> @@ -383,7 +383,9 @@ struct kvm_trace_rec { > >> #define KVM_CAP_MP_STATE 14 > >> #define KVM_CAP_COALESCED_MMIO 15 > >> #define KVM_CAP_SYNC_MMU 16 /* Changes to host mmap are reflected > >> in guest */ +#ifdef CONFIG_X86 > >> #define KVM_CAP_DEVICE_ASSIGNMENT 17 > >> +#endif > > > > I didn't see this changed to also accomodate IA64 in the patchset. > > Since linux-ia64 DMAR is not ready in kvm.git, and it should be in > linux-ia64.git. So it should be in kvm.git once Avi merged with OK; Does Linus' tree currently have the necessary support? Also, I think you'll have to redo the patch 1/8 after Weidong's mmio patch got merged. > upstream, so I didn't enable it for kvm/ia64 now. You know, S390 has no > pci support, so if we put the code in kvm_mainc, we should use the macro > to exclude other arch which doesn't need device assignments. If DMAR is > ready for kvm.git, I will change this macro as following: > #if defined(CONFIG_X86) || defined(CONFIG_IA64) > #define KVM_CAP_DEVICE_ASSIGNMENT 17 > #endif Yes, that's what I meant. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH 2/8]kvm: Moving device_assignment logic to kvm_main.c Date: Fri, 3 Oct 2008 13:12:51 +0530 Message-ID: <200810031312.52056.amit.shah@redhat.com> References: <42DFA526FC41B1429CE7279EF83C6BDC01A53DF4@pdsmsx415.ccr.corp.intel.com> <200810031239.54863.amit.shah@redhat.com> <42DFA526FC41B1429CE7279EF83C6BDC01A541E8@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org, avi@redhat.com To: "Zhang, Xiantao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54489 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbYJCHoL (ORCPT ); Fri, 3 Oct 2008 03:44:11 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A541E8@pdsmsx415.ccr.corp.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: * On Friday 03 Oct 2008 13:02:05 Zhang, Xiantao wrote: > Amit Shah wrote: > > * On Monday 29 Sep 2008 10:56:29 Zhang, Xiantao wrote: > >> From: Xiantao Zhang > >> Date: Sat, 27 Sep 2008 10:59:36 +0800 > >> Subject: [PATCH] kvm: Moving device_assignment logic to kvm_main.c > >> > >> To share with other archs, this patch moves device_assignment > >> logic to common parts. > >> Signed-off-by: Xiantao Zhang > >> > >> diff --git a/include/linux/kvm.h b/include/linux/kvm.h > >> index 4269be1..9acf34a 100644 > >> --- a/include/linux/kvm.h > >> +++ b/include/linux/kvm.h > >> @@ -383,7 +383,9 @@ struct kvm_trace_rec { > >> #define KVM_CAP_MP_STATE 14 > >> #define KVM_CAP_COALESCED_MMIO 15 > >> #define KVM_CAP_SYNC_MMU 16 /* Changes to host mmap are reflected > >> in guest */ +#ifdef CONFIG_X86 > >> #define KVM_CAP_DEVICE_ASSIGNMENT 17 > >> +#endif > > > > I didn't see this changed to also accomodate IA64 in the patchset. > > Since linux-ia64 DMAR is not ready in kvm.git, and it should be in > linux-ia64.git. So it should be in kvm.git once Avi merged with OK; Does Linus' tree currently have the necessary support? Also, I think you'll have to redo the patch 1/8 after Weidong's mmio patch got merged. > upstream, so I didn't enable it for kvm/ia64 now. You know, S390 has no > pci support, so if we put the code in kvm_mainc, we should use the macro > to exclude other arch which doesn't need device assignments. If DMAR is > ready for kvm.git, I will change this macro as following: > #if defined(CONFIG_X86) || defined(CONFIG_IA64) > #define KVM_CAP_DEVICE_ASSIGNMENT 17 > #endif Yes, that's what I meant.