From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Date: Fri, 3 Oct 2008 13:27:18 +0200 Message-ID: <200810031327.19293.rjw@sisk.pl> References: <200808290002.55026.rjw@sisk.pl> <200809300010.39000.rjw@sisk.pl> <20081003013557.42ce685d.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:39054 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752240AbYJCLXU (ORCPT ); Fri, 3 Oct 2008 07:23:20 -0400 In-Reply-To: <20081003013557.42ce685d.akpm@linux-foundation.org> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andrew Morton Cc: Jeff Garzik , Tejun Heo , ACPI Devel Maling List , linux-ide@vger.kernel.org, Thomas Renninger , Robert Hancock , LKML , Frans Pop , Maciej Rutecki On Friday, 3 of October 2008, Andrew Morton wrote: > On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki" wrote: > > > Hibernation: Introduce new system state for the last phase of hibernation > > > > Replace unused SYSTEM_SUSPEND_DISK with a new system_state value > > SYSTEM_HIBERNATE_ENTER that can be used by device drivers to check if > > the system is in the last phase of hibernation. > > Violent objections. > > We just don't know what this change will do. It potentially affects > every code site in the kernel which looks at system_state. Do you mean anyone checking 'system_state != SOMETHING' ? Oh well. > We've had problems in the past with this thing and the more complex we make it, > the worse any future problems will be. It's Just Bad. > > Can we just create a new global? > > extern bool system_entering_hibernation_or_whatever; Yes, we can, but what about: extern bool system_entering_hibernation(void); that will become a static inline in case of !CONFIG_HIBERNATION, and using a static variable?