All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, rnayak@ti.com, Tero.Kristo@nokia.com
Subject: Re: [PATCH] OMAP3 clock: fix dss1_alwon_fck
Date: Fri, 3 Oct 2008 16:45:07 +0300	[thread overview]
Message-ID: <20081003134506.GD6251@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0809250807330.14535@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [080925 17:09]:
> 
> Commit a63efb1547ac35dcb0f007090396a3c7510eb691 broke the dss1_alwon_fck
> clock enable on 3430ES2+.  The clock code was not waiting for the module
> to come out of idle.
> 
> Problem reported by Rajendra Nayak <rnayak@ti.com>.

Pushing.

Tony

> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> ---
>  arch/arm/mach-omap2/clock34xx.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
> index 8ce7097..4722277 100644
> --- a/arch/arm/mach-omap2/clock34xx.h
> +++ b/arch/arm/mach-omap2/clock34xx.h
> @@ -2304,7 +2304,7 @@ static struct clk dss1_alwon_fck_3430es1 = {
>  	.prcm_mod	= OMAP3430_DSS_MOD,
>  	.enable_reg	= CM_FCLKEN,
>  	.enable_bit	= OMAP3430_EN_DSS1_SHIFT,
> -	.flags		= CLOCK_IN_OMAP343X,
> +	.flags		= CLOCK_IN_OMAP3430ES1,
>  	.clkdm		= { .name = "dss_clkdm" },
>  	.recalc		= &followparent_recalc,
>  };
> @@ -2317,7 +2317,7 @@ static struct clk dss1_alwon_fck_3430es2 = {
>  	.enable_reg	= CM_FCLKEN,
>  	.enable_bit	= OMAP3430_EN_DSS1_SHIFT,
>  	.idlest_bit	= OMAP3430ES2_ST_DSS_IDLE_SHIFT,
> -	.flags		= CLOCK_IN_OMAP343X | WAIT_READY,
> +	.flags		= CLOCK_IN_OMAP3430ES2 | WAIT_READY,
>  	.clkdm		= { .name = "dss_clkdm" },
>  	.recalc		= &followparent_recalc,
>  };
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-10-03 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 14:08 [PATCH] OMAP3 clock: fix dss1_alwon_fck Paul Walmsley
2008-10-03 13:45 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081003134506.GD6251@atomide.com \
    --to=tony@atomide.com \
    --cc=Tero.Kristo@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.