From: Arjan van de Ven <arjan@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: Add a C-state tracer to help power optimization
Date: Fri, 3 Oct 2008 22:33:47 -0700 [thread overview]
Message-ID: <20081003223347.27aa25ba@infradead.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0810032003140.17863@gandalf.stny.rr.com>
On Fri, 3 Oct 2008 20:32:51 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Hi Arjan,
>
> Very nice! I just have a few comments below.
since this is my first tracer.... I would suggest having a "golden
example" one that people can copy (it seems I copied a less than
perfect one ;-)... maybe a trace_example.c ?
I'll look into your comments tomorrow when I'm more awake.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-10-04 5:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 23:55 [PATCH] ftrace: Add a C-state tracer to help power optimization Arjan van de Ven
2008-10-03 23:57 ` [PATCH 2/2] cstate ftrace userland script Arjan van de Ven
2008-10-04 0:32 ` [PATCH] ftrace: Add a C-state tracer to help power optimization Steven Rostedt
2008-10-04 5:33 ` Arjan van de Ven [this message]
2008-10-04 5:45 ` Steven Rostedt
2008-10-04 8:32 ` Ingo Molnar
2008-10-04 16:52 ` Arjan van de Ven
2008-10-04 17:15 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003223347.27aa25ba@infradead.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.