From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Len Brown <lenb@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] r8169: WoL fixes
Date: Sat, 4 Oct 2008 20:10:17 +0200 [thread overview]
Message-ID: <200810042010.17948.rjw@sisk.pl> (raw)
In-Reply-To: <20081004180834.71c1bdf2@neptune.home>
On Saturday, 4 of October 2008, Bruno Prémont wrote:
> Since recent kernel (2.6.26 or 2.6.27) the PCI wakeup functions are
> influenced by generic device ability and configuration when enabling
> PCI-device triggered wake-up.
>
> This patch causes WoL setting to enable/disable device's wish to
> be permitted to wake-up the host when changing WoL options and
> also during device probing.
>
> Without this patch one has write 'enabled' to
> /sys/bus/pci/devices/0000:02:08.0/power/wakeup
>
> Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> --- linux-2.6.27-rc8-git6.orig/drivers/net/r8169.c 2008-10-04 12:31:48.000000000 +0200
> +++ linux-2.6.27-rc8-git6/drivers/net/r8169.c 2008-10-04 16:51:48.000000000 +0200
> @@ -619,6 +619,7 @@ static int rtl8169_set_wol(struct net_de
> tp->features |= RTL_FEATURE_WOL;
> else
> tp->features &= ~RTL_FEATURE_WOL;
> + device_set_wakeup_enable(&tp->pci_dev->dev, wol->wolopts);
>
> spin_unlock_irq(&tp->lock);
>
> @@ -1796,6 +1797,7 @@ rtl8169_init_one(struct pci_dev *pdev, c
> }
>
> rtl8169_init_phy(dev, tp);
> + device_set_wakeup_enable(&pdev->dev, tp->features & RTL_FEATURE_WOL);
>
> out:
> return rc;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-10-04 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 16:05 [PATCH 0/2] r8169: WoL fixes Bruno Prémont
2008-10-04 16:07 ` [PATCH 1/2] " Bruno Prémont
2008-10-04 16:08 ` [PATCH 2/2] " Bruno Prémont
2008-10-04 18:10 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810042010.17948.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=bonbons@linux-vserver.org \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.