From: Matthew Garrett <mjg59@srcf.ucam.org>
To: dmitry.torokhov@gmail.com, IvDoorn@gmail.com, hmh@hmh.eng.br
Cc: sitsofe@yahoo.com, linux-kernel@vger.kernel.org
Subject: [PATCH] rfkill-input doesn't work until 5 minutes after boot
Date: Sat, 4 Oct 2008 21:43:43 +0100 [thread overview]
Message-ID: <20081004204342.GA29620@srcf.ucam.org> (raw)
rfkill-input implements debounce as follows:
if (time_after(jiffies, task->last + msecs_to_jiffies(200))) {
However, task->last is initialised to 0 while jiffies starts at -300*HZ.
Any input within 5 minutes of kernel start is therefore ignored. Fix by
initialising task->last correctly.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
.27 material?
diff --git a/net/rfkill/rfkill-input.c b/net/rfkill/rfkill-input.c
index e5b6955..de75934 100644
--- a/net/rfkill/rfkill-input.c
+++ b/net/rfkill/rfkill-input.c
@@ -101,6 +101,7 @@ static void rfkill_schedule_toggle(struct rfkill_task *task)
.mutex = __MUTEX_INITIALIZER(n.mutex), \
.lock = __SPIN_LOCK_UNLOCKED(n.lock), \
.desired_state = RFKILL_STATE_UNBLOCKED, \
+ .last = INITIAL_JIFFIES, \
}
static DEFINE_RFKILL_TASK(rfkill_wlan, RFKILL_TYPE_WLAN);
--
Matthew Garrett | mjg59@srcf.ucam.org
next reply other threads:[~2008-10-04 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 20:43 Matthew Garrett [this message]
2008-10-04 22:03 ` [PATCH] rfkill-input doesn't work until 5 minutes after boot Sitsofe Wheeler
2008-10-04 22:39 ` Andrew Morton
2008-10-04 22:50 ` Matthew Garrett
2008-10-05 0:43 ` [PATCH v2] " Matthew Garrett
2008-10-05 4:43 ` Andrew Morton
2008-10-05 10:58 ` Matthew Garrett
2008-10-05 11:02 ` [PATCH v3] " Matthew Garrett
2008-10-05 13:51 ` Henrique de Moraes Holschuh
2008-10-05 14:31 ` Ivo van Doorn
2008-10-06 2:16 ` Henrique de Moraes Holschuh
2008-10-05 19:04 ` Sitsofe Wheeler
2008-10-05 21:24 ` Dmitry Torokhov
2008-10-05 21:33 ` Matthew Garrett
2008-10-06 5:52 ` Sitsofe Wheeler
2008-10-06 16:31 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081004204342.GA29620@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=IvDoorn@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=sitsofe@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.