Re: [PATCH 4/5] ath5k: Fix SREV reporting after SREV updates

[Bob Copeland <me@bobcopeland.com>]

On Mon, Sep 29, 2008 at 01:24:44AM +0300, Nick Kossifidis wrote:
>  * Fix srev reporting during attach
> 
>  Changes-Licensed-under: ISC
>  Signed-Off-by: Nick Kossifidis <mickflemm@gmail.com>

This now identifies my card as 5414, whereas ath5k used to call it 5424 
(mac srev 0xa3, phy 0x61).  

But, madwifi has:
 #define AR5K_SREV_VER_AR5424     0xa3 /* PCI-E */

It still works so not a major problem, but who's right?

> @@ -396,7 +396,11 @@ ath5k_chip_name(enum ath5k_srev_type type, u_int16_t val)
>  	for (i = 0; i < ARRAY_SIZE(srev_names); i++) {
>  		if (srev_names[i].sr_type != type)
>  			continue;
> -		if ((val & 0xff) < srev_names[i + 1].sr_val) {
> +
> +		if ((val & 0xf0) == srev_names[i].sr_val)
> +			name = srev_names[i].sr_name;
> +
> +		if ((val & 0xff) == srev_names[i].sr_val) {
>  			name = srev_names[i].sr_name;
>  			break;
>  		}
> 

-- 
Bob Copeland %% www.bobcopeland.com