Re: [patch/rfc/rft 2.6.27-rc8-omap-git] twl4030-pwrirq simplification, cleanup

[David Brownell <david-b@pacbell.net>]

On Monday 06 October 2008, Felipe Balbi wrote:
> On Mon, Oct 06, 2008 at 01:19:18AM -0700, David Brownell wrote:
> > ...
> >
> > (This is similar to the GPIO patch I just sent, but simpler
> > except for the impact on the few drivers thinking oddly
> > about IRQs.  Those patches cover the key SIH modules, and
> > a similar one affects the PIH in twl4030-core.)
> 
> What are the dependencies for this patch ? It doesn't apply cleanly.

Applies against current GIT with a few minor offsets caused
by the patch working around the i2c-omap timeouts.  I've sent
that before; it's appended for reference.


---
 drivers/i2c/chips/twl4030-pwrirq.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

--- a/drivers/i2c/chips/twl4030-pwrirq.c
+++ b/drivers/i2c/chips/twl4030-pwrirq.c
@@ -161,6 +161,8 @@ static int twl4030_pwrirq_thread(void *d
 	return 0;
 }
 
+#include <linux/delay.h>
+
 static int __init twl4030_pwrirq_init(void)
 {
 	int i, err;
@@ -168,8 +170,16 @@ static int __init twl4030_pwrirq_init(vo
 	twl4030_pwrirq_mask = 0xff;
 	twl4030_pwrirq_pending_unmask = 0;
 
+/* HEY:  core already did this.
+ * But that's surely not why we
+ * sometimes see i2c timeouts here ...
+ */
+for (i = 0; i < 5; i++) {
 	err = twl4030_i2c_write_u8(TWL4030_MODULE_INT, twl4030_pwrirq_mask,
 					TWL4030_INT_PWR_IMR1);
+if (!err) break;
+msleep(10);
+}
 	if (err)
 		return err;