From: Arjan van de Ven <arjan@infradead.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>,
mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ftrace: Add a C-state tracer to help power optimization
Date: Mon, 6 Oct 2008 09:57:07 -0700 [thread overview]
Message-ID: <20081006095707.0c1b5a23@infradead.org> (raw)
In-Reply-To: <1223311960.12409.28.camel@lappy.programming.kicks-ass.net>
On Mon, 06 Oct 2008 18:52:39 +0200
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> >
> >
> > #endif /* _LINUX_FTRACE_H */
>
> Why have the cstate_trace structure? If you just log start, stop you
> could compute the time delta from the trace time stamps, no?
there's 2 other fields I need than just the timestamp.
>
> If you decide to keep the structure, perhaps declare it empty for !
> CONFIG_CSTATE_TRACER so as to not bloat stack usage when its not
> configured.
ok good point
>
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-10-06 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 17:54 [PATCH v2] ftrace: Add a C-state tracer to help power optimization Arjan van de Ven
2008-10-04 18:17 ` Steven Rostedt
2008-10-04 18:29 ` Arjan van de Ven
2008-10-06 16:52 ` Peter Zijlstra
2008-10-06 16:57 ` Arjan van de Ven [this message]
2008-10-05 9:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006095707.0c1b5a23@infradead.org \
--to=arjan@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.