Re: [PATCH] TPROXY cleanups

[KOVACS Krisztian <hidden@sch.bme.hu>]

Hi,

On h, okt 06, 2008 at 04:39:21 +0400, Alexey Dobriyan wrote:
> On Mon, Oct 06, 2008 at 02:26:03PM +0200, KOVACS Krisztian wrote:
> > On h, okt 06, 2008 at 04:19:44 +0400, Alexey Dobriyan wrote:
> > > * drop version.h -- unneeded and file will be needlessly rebuilt.
> > > * make tproxy_core unloadable
> > > * use "in" device outright, -- target and match are only in PRE_ROUTING,
> > >   so should avoid dereference.
> 
> > > @@ -89,7 +88,11 @@ static int __init nf_tproxy_init(void)
> > >  	return 0;
> > >  }
> > >  
> > > +static void __exit nf_tproxy_exit(void)
> > > +{
> > > +}
> > >  module_init(nf_tproxy_init);
> > > +module_exit(nf_tproxy_exit);
> > 
> > Please don't do this. The module was made unloadable because it attaches a
> > function pointer to skb's and removing the module while there's an skb in
> > flight would cause a kernel crash.
> 
> Have you actually seen it?

No.

> xt_TPROXY will pin it because it uses a symbol from it, so it won't
> dissapear.

Yeah, that's true, and I think that it's impossible to remove the rule
attaching the socket references while the skb's in flight. Ok, so let's
add module_exit() then.

-- 
KOVACS Krisztian