From: "John W. Linville" <linville@tuxdriver.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: Tomas Winkler <tomasw@gmail.com>,
linux-wireless@vger.kernel.org, yi.zhu@intel.com
Subject: Re: [PATCH 1/2] iwlwifi: fix compliation warning in iwl-agn-rs.c when CONFIG_IWLWIFI_DEBUG is not set.
Date: Mon, 6 Oct 2008 15:03:02 -0400 [thread overview]
Message-ID: <20081006190301.GE3448@tuxdriver.com> (raw)
In-Reply-To: <eb3ff54b0810060811p4798e4c0va59c5375d004f53d@mail.gmail.com>
On Mon, Oct 06, 2008 at 05:11:40PM +0200, Rami Rosen wrote:
> Second, this is also a possible solution; looking at the function
> immediately above in the same file (rs_clear() in iwl-agn-rs.c)
> we can see the same usage of #ifdef CONFIG_IWLWIFI_DEBUG
> and not __maybe_unused.
> I wonder: does the "__maybe_unused" solution better than the #ifdef
> solution in any aspect?
Yes.
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
prev parent reply other threads:[~2008-10-06 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 13:58 [PATCH 1/2] iwlwifi: fix compliation warning in iwl-agn-rs.c when CONFIG_IWLWIFI_DEBUG is not set Rami Rosen
2008-10-06 14:41 ` Tomas Winkler
2008-10-06 15:11 ` Rami Rosen
2008-10-06 19:03 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006190301.GE3448@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ramirose@gmail.com \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.