All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-rt-users@vger.kernel.org
Cc: rostedt@goodmis.org
Subject: PF_HARDIRQ used in preempt-realtime-core.patch
Date: Mon, 6 Oct 2008 15:49:29 -0400	[thread overview]
Message-ID: <20081006194928.GA14183@windriver.com> (raw)

I noticed that preempt-realtime-core.patch does this to hardirq.h:

-#define in_irq()               (hardirq_count())
-#define in_softirq()           (softirq_count())
-#define in_interrupt()         (irq_count())
+#define in_irq()       (hardirq_count() || (current->flags & PF_HARDIRQ))
+#define in_softirq()   (softirq_count() || (current->flags & PF_SOFTIRQ))
+#define in_interrupt() (irq_count())

I was thinking that in order to have better patch bisection for future
hard/softirq segmentation, that this chunk would be better suited to
live in preempt-irqs-core.patch (where PF_HARDIRQ is introduced).

That would reduce the preempt-realtime-core.patch for hardirq.h to just
one line, if we drop the whitespace shuffling in there at the same time.

I can send diffs of the existing 26rt9 patches, but I'm not sure how useful
folks would find diffs of diffs (if any at all.).  Since it doesn't
impact the actual code base of the resulting patched tree, the other
option is to just ignore it for 26 but keep it in mind for the future.

Paul.

             reply	other threads:[~2008-10-06 19:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 19:49 Paul Gortmaker [this message]
2008-10-06 20:20 ` PF_HARDIRQ used in preempt-realtime-core.patch Sven-Thorsten Dietrich
2008-10-06 21:11   ` Paul Gortmaker
2008-10-06 21:22     ` Sven-Thorsten Dietrich
2008-10-07 14:54       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081006194928.GA14183@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.