Re: [PATCH 04/10] ARM: OMAP2: Remove OMAP_PRM_REGADDR, OMAP_CM_REGADDR

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Mon, Oct 06, 2008 at 05:18:49PM +0100, Russell King - ARM Linux wrote:
> On Thu, Oct 02, 2008 at 10:37:52AM -0600, Paul Walmsley wrote:
> > From: Tony Lindgren <tony@atomide.com>
> > 
> > Remove OMAP_PRM_REGADDR and OMAP_CM_REGADDR.  Use
> > prm_read/write_mod_reg() or cm_read/write_mod_reg() instead.  For
> > assembly, use OMAPXXXX_PRM_REGADDR or OMAPXXXX_CM_REGADDR macros.
> 
> I do have concerns about this patch as well - hating those casts
> that are required to store an offset in 'enable_reg', which then
> have to be un-casted to add the correct base address.
> 
> I've been trying to work out if there's a better way to do this
> using the existing structures.  How about:

I've modified this idea slightly, since using a mask instead of bit
numbers makes it possible to remove more special casing... and I also
have a perl script to convert the clock definitions.

One thing I've noticed, however, is that there seem to be clocks which
result in omap2_clk_wait_ready() being called, which checks the "other"
F or I clock register, but there's no corresponding clock defined in
the source for that bit.  Eg, iva1_ifck in clock24xx.h.  What does it
mean?