From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/4] vfs: vfs-level fiemap interface Date: Tue, 7 Oct 2008 06:12:07 -0400 Message-ID: <20081007101207.GA10406@infradead.org> References: <1223071147-27180-1-git-send-email-tytso@mit.edu> <1223071147-27180-2-git-send-email-tytso@mit.edu> <20081004021251.GA29174@mit.edu> <48EA55AC.2060102@hp.com> <20081006210706.GB8139@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jim owens , linux-fsdevel@vger.kernel.org, Mark Fasheh , Michael Kerrisk , linux-abi@vger.kernel.org To: Theodore Tso Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:37075 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbYJGKML (ORCPT ); Tue, 7 Oct 2008 06:12:11 -0400 Content-Disposition: inline In-Reply-To: <20081006210706.GB8139@mit.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Oct 06, 2008 at 05:07:06PM -0400, Theodore Tso wrote: > +* FIEMAP_EXTENT_NO_UNMOUNTED_IO > +Accessing the data in this extent via I/O to the block device while the > +filesystem is unmounted is illegal or will have undefined results. This > +may be because the data is somehow encrypted or compressed by the filesystem. > +Note that accessing the data using the information returned by the > +FIEMAP interface while the filesystem is mounted is *always* undefined > +should not be attempted by user applications. I think the point we're trying to get down to is that this is not just a normal block that you can access using a block number but some complicated encoding scheme. Maybe * FIEMAP_EXTENT_ENCODED This extent does not consistant of plain filesystem blocks but is encoded (e.g. encrypted or compressed) or shared with other data by the filesystem. Accessing the data in this extent via I/O to the block device will have undefined resuts. Note that accessing the data using the information returned by the FIEMAP interface while the filesystem is mounted is *always* undefined should not be attempted by user applications. Except for continuous nitpicking about this flag which could be continued in mainline before a release this patch looks good to me.