From: "John W. Linville" <linville@tuxdriver.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Holger Schurig <hs4233@mail.mn-solutions.de>,
linux-wireless@vger.kernel.org, Tomas Winkler <tomasw@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap
Date: Tue, 7 Oct 2008 09:16:28 -0400 [thread overview]
Message-ID: <20081007131615.GR3448@tuxdriver.com> (raw)
In-Reply-To: <20081007071529.GA5010@infradead.org>
On Tue, Oct 07, 2008 at 03:15:29AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 07, 2008 at 08:21:56AM +0200, Holger Schurig wrote:
> > > I don't want these macros eithers but I NACK any patches with
> > > cursing in the commit logs.
> >
> > I fully agree. There's no need to speak about "crap" when
> > changing other people's code. In some cultures thats quite
> > insulting.
>
> Well, it is crap. Looks at it objectively. It's a perfectly fine
> description and most of us use it perfectly happily for our own code,
> too.
I agree that this is at worst a little bit rude. The patch should be
rejected or merged on its own basis, although I do reserve the right
to edit a changelog from time to time... :-)
Now, can we discuss the patch rather than Johannes' intemperate
word choice?
John
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
next prev parent reply other threads:[~2008-10-07 13:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 16:50 [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap Johannes Berg
2008-10-06 17:45 ` Johannes Berg
2008-10-06 17:49 ` [PATCH v2] " Johannes Berg
2008-10-06 18:18 ` Marcel Holtmann
2008-10-06 18:24 ` Johannes Berg
2008-10-06 18:35 ` [PATCH] " Tomas Winkler
2008-10-06 19:12 ` Marcel Holtmann
2008-10-06 20:24 ` drago01
2008-10-06 21:32 ` Christoph Hellwig
2008-10-07 6:21 ` Holger Schurig
2008-10-07 7:15 ` Christoph Hellwig
2008-10-07 13:16 ` John W. Linville [this message]
2008-10-07 14:03 ` Tomas Winkler
2008-10-07 16:58 ` Johannes Berg
2008-10-07 19:28 ` Tomas Winkler
2008-10-07 19:34 ` Johannes Berg
2008-10-07 19:39 ` Johannes Berg
2008-10-07 20:06 ` Tomas Winkler
2008-10-07 20:10 ` Johannes Berg
2008-10-07 20:46 ` Tomas Winkler
2008-10-08 8:02 ` Johannes Berg
2008-10-08 12:38 ` Tomas Winkler
2008-10-09 9:52 ` Johannes Berg
2008-10-09 16:35 ` Tomas Winkler
2008-10-07 20:01 ` Tomas Winkler
2008-10-07 20:06 ` Johannes Berg
2008-10-07 20:08 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007131615.GR3448@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hch@infradead.org \
--cc=hs4233@mail.mn-solutions.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.