Re: cxgb3 - fix race in EEH

[David Miller <davem@davemloft.net>]

I've applied this patch to net-next-2.6, BUT...

You should show some signs of life and address the things
Andrew Morton asked you about when you posted this patch.

His questions and comments are included for your reference:

----------------------------------------
It's deeply weird that t3_reset_qset() does

	memset(&q->tx_reclaim_timer, 0, sizeof(q->tx_reclaim_timer));

There are lots of things in the timer_list which the driver has no
business modifying.  For example, this might break the metadata in
Thomas's debugobjects stuff, which attempts to catch things being done
in the wrong order (I don't think it will, but still...).

Rerunning init_timer() should repair the damage, but I suspect a simple

	q->tx_reclaim_timer.function = NULL;	/* explanation goes here */

would suffice here.


t3_sge_alloc_qset() could use the newer setup_timer().
----------------------------------------