From: "Shawn O. Pearce" <spearce@spearce.org>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Alex Riesen <raa.lkml@gmail.com>,
Constantine Plotnikov <constantine.plotnikov@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Implement git clone -v
Date: Tue, 7 Oct 2008 23:02:57 -0700 [thread overview]
Message-ID: <20081008060257.GA15240@spearce.org> (raw)
In-Reply-To: <20081007193956.GB536@genesis.frugalware.org>
Miklos Vajna <vmiklos@frugalware.org> wrote:
> On Tue, Oct 07, 2008 at 08:21:28AM +0200, Alex Riesen <raa.lkml@gmail.com> wrote:
> > Yes. Does it work? :)
>
> Yes, it does. I'm not sure how to test it from the testsuite, maybe
> redirect the output to a file and grep in it? It's ugly, that's why I
> did not do so, but if you think a testcase is a musthave for this
> feature then that's the way to go, I guess.
Actually its not a bad way to test the feature. Normally we disable
progress if stdout is not a tty. If you redirect to a file then
-v should be needed to get anything at all on stderr.
You may be able to just test the size of the file:
git fetch -v ... >out 2>err &&
test -s err
--
Shawn.
next prev parent reply other threads:[~2008-10-08 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 20:01 Forcing progerss output for clone Constantine Plotnikov
2008-10-04 21:42 ` Alex Riesen
2008-10-06 22:19 ` [PATCH] Implement git clone -v Miklos Vajna
2008-10-07 6:21 ` Alex Riesen
2008-10-07 19:39 ` Miklos Vajna
2008-10-08 6:02 ` Shawn O. Pearce [this message]
2008-10-08 6:25 ` Alex Riesen
2008-10-08 23:40 ` Miklos Vajna
2008-10-09 11:06 ` Junio C Hamano
2008-10-09 15:20 ` Shawn O. Pearce
2008-10-09 21:26 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008060257.GA15240@spearce.org \
--to=spearce@spearce.org \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.