From: Amit Shah <amit.shah@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Unregister IRQ ACK notifier with in-kernel irqchip
Date: Wed, 8 Oct 2008 12:38:52 +0530 [thread overview]
Message-ID: <200810081238.52574.amit.shah@redhat.com> (raw)
In-Reply-To: <1223447960-30355-1-git-send-email-sheng@linux.intel.com>
* On Wednesday 08 Oct 2008 12:09:20 Sheng Yang wrote:
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
> arch/x86/kvm/x86.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 675fcc1..c5763d7 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -176,7 +176,9 @@ static void kvm_free_assigned_device(struct kvm *kvm,
> if (irqchip_in_kernel(kvm) && assigned_dev->irq_requested)
> free_irq(assigned_dev->host_irq, (void *)assigned_dev);
>
> - kvm_unregister_irq_ack_notifier(kvm, &assigned_dev->ack_notifier);
> + if (irqchip_in_kernel(kvm))
> + kvm_unregister_irq_ack_notifier(kvm,
> + &assigned_dev->ack_notifier);
The unregister API should perform the check whether the said notifier exists
so this shouldn't be necessary.
next prev parent reply other threads:[~2008-10-08 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 6:39 [PATCH] KVM: Unregister IRQ ACK notifier with in-kernel irqchip Sheng Yang
2008-10-08 7:08 ` Amit Shah [this message]
2008-10-08 8:54 ` Sheng Yang
2008-10-08 9:04 ` Sheng Yang
2008-10-08 9:20 ` Amit Shah
2008-10-08 9:32 ` Sheng Yang
2008-10-08 9:46 ` [PATCH] KVM: IRQ ACK notifier should be used " Sheng Yang
2008-10-08 9:28 ` [PATCH 1/1] " Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810081238.52574.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.