From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>,
Felipe Balbi <me@felipebalbi.com>,
"Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: [PATCH 2.6.27-rc9-omap] i2c-omap: timeouts begone
Date: Wed, 8 Oct 2008 14:36:05 -0700 [thread overview]
Message-ID: <200810081436.06810.david-b@pacbell.net> (raw)
In-Reply-To: <200810081236.48940.david-b@pacbell.net>
I can tell someone's going to want a fix that's a
lot more power-aware ... ;)
This seems to remove the need for the "hack" patch.
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -202,6 +202,9 @@ static void omap_i2c_put_clocks(struct omap_i2c_dev *dev)
static void omap_i2c_unidle(struct omap_i2c_dev *dev)
{
+ if (1)
+ return;
+
if (dev->iclk != NULL)
clk_enable(dev->iclk);
clk_enable(dev->fclk);
@@ -214,6 +217,9 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
{
u16 iv;
+ if (1)
+ return;
+
dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
if (dev->rev1)
next prev parent reply other threads:[~2008-10-08 21:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 18:07 kernel oops for 3430sdp Aguirre Rodriguez, Sergio Alberto
2008-10-07 18:28 ` David Brownell
2008-10-07 19:29 ` Aguirre Rodriguez, Sergio Alberto
2008-10-07 20:09 ` Felipe Balbi
2008-10-08 14:55 ` [PATCH] twl4030: Fix pwrirq by making sure the module is responding (Re: kernel oops for 3430sdp) Tony Lindgren
2008-10-08 18:05 ` David Brownell
2008-10-08 18:38 ` Tony Lindgren
2008-10-08 19:19 ` David Brownell
2008-10-08 19:36 ` David Brownell
2008-10-08 21:36 ` David Brownell [this message]
2008-10-08 21:54 ` [PATCH 2.6.27-rc9-omap] i2c-omap: timeouts begone Felipe Balbi
2008-10-08 22:35 ` Woodruff, Richard
2008-10-10 11:36 ` Paul Walmsley
2008-10-08 23:38 ` Woodruff, Richard
2008-10-09 1:09 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810081436.06810.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=saaguirre@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.