From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip Date: Wed, 8 Oct 2008 16:29:59 +0800 Message-ID: <200810081629.59746.sheng@linux.intel.com> References: <20081002164559.GA16709@yukikaze> <200810031306.53295.amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "'kvm@vger.kernel.org'" To: Amit Shah Return-path: Received: from mga06.intel.com ([134.134.136.21]:40339 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751210AbYJHIbK (ORCPT ); Wed, 8 Oct 2008 04:31:10 -0400 In-Reply-To: <200810031306.53295.amit.shah@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Friday 03 October 2008 15:36:53 Amit Shah wrote: > * On Thursday 02 Oct 2008 22:15:59 Sheng Yang wrote: > > /* This should be called with the kvm->lock mutex held */ > > -void kvm_set_irq(struct kvm *kvm, int irq, int level) > > +void kvm_set_irq(struct kvm *kvm, int irq, int level, int irq_source_id) > > Just one thing: can you make the irq_source_id argument the 3rd one and > the 'level' as the last one? It's clearer to think of it that way. > > I'll test this next week. Hi, Amit Do you have any update on this patch? Thanks! -- regards Yang, Sheng