From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 3/4] x86: Add MSI delivery mode mask Date: Wed, 8 Oct 2008 16:52:55 +0800 Message-ID: <200810081652.55444.sheng@linux.intel.com> References: <1223455093-304-1-git-send-email-sheng@linux.intel.com> <1223455093-304-4-git-send-email-sheng@linux.intel.com> <42DFA526FC41B1429CE7279EF83C6BDC01ABCD4B@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: "Avi Kivity" , kvm@vger.kernel.org To: "Zhang, Xiantao" Return-path: Received: from mga06.intel.com ([134.134.136.21]:8968 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754166AbYJHIym (ORCPT ); Wed, 8 Oct 2008 04:54:42 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01ABCD4B@pdsmsx415.ccr.corp.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 08 October 2008 16:48:11 Zhang, Xiantao wrote: > Hi, Sheng > Since these macros are just used by kvm, and considering cross-arch > support, could you move these stuff to include/linux/kvm_host.h ? So > they can be shared for x86 and ia64. > Thanks > Xiantao I don't think so... The problem is, we can't assume that IA64 and x86 use same MSI format, and I think we shouldn't do that. And this patch just modify x86 host linux side. So if they can be shared, host kernel side should also share them, then this file(msidef.h) shouldn't put on include/asm-x86/... So for now, probably it's more reasonable to keep it here. Thanks! -- regards Yang, Sheng > > Sheng Yang wrote: > > Signed-off-by: Sheng Yang > > --- > > include/asm-x86/msidef.h | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/include/asm-x86/msidef.h b/include/asm-x86/msidef.h > > index 296f29c..fdeebbb 100644 > > --- a/include/asm-x86/msidef.h > > +++ b/include/asm-x86/msidef.h > > @@ -15,8 +15,11 @@ > > MSI_DATA_VECTOR_MASK) > > > > #define MSI_DATA_DELIVERY_MODE_SHIFT 8 > > +#define MSI_DATA_DELIVERY_MODE_MASK 0x700 > > #define MSI_DATA_DELIVERY_FIXED (0 << > > MSI_DATA_DELIVERY_MODE_SHIFT) > > > #define MSI_DATA_DELIVERY_LOWPRI (1 << > > MSI_DATA_DELIVERY_MODE_SHIFT) > > > +#define MSI_DATA_DELIVERY_FIXED_VAL 0 > > +#define MSI_DATA_DELIVERY_LOWPRI_VAL 1 > > > > #define MSI_DATA_LEVEL_SHIFT 14 > > #define MSI_DATA_LEVEL_DEASSERT (0 << > > MSI_DATA_LEVEL_SHIFT) > > > -- > > 1.5.4.5