From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [mmotm 02/Oct] fix buid error of hid-core
Date: Thu, 9 Oct 2008 00:02:08 -0700 [thread overview]
Message-ID: <20081009000208.d902be73.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081009154404.DED3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Thu, 9 Oct 2008 15:45:19 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> Ping!
I'm in hiding until linux-next comes back.
> > Patch against: mmotm 02 Oct
> > Applied after: usb-usb-remove-warn-macro-from-usbh.patch
> >
> > fix following buiild error
> >
> > -------------------------
> > CC [M] drivers/hid/usbhid/hid-core.o
> > drivers/hid/usbhid/hid-core.c: In function 'usbhid_submit_report':
> > drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_driver_string'
> > drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_name'
> > drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_driver_string'
> > drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_name'
> > drivers/hid/usbhid/hid-core.c: In function 'usbhid_init_reports':
> > drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_driver_string'
> > drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_name'
> > make[3]: *** [drivers/hid/usbhid/hid-core.o] Error 1
> > make[2]: *** [drivers/hid/usbhid] Error 2
> > make[1]: *** [drivers/hid] Error 2
> > make: *** [drivers] Error 2
Attempting to remove a widely-used macro in a single patch within our
distributed development model was, frankly, short-sighted to the point
of stupidity. I've had enough of dealing with stuff like this. If
Stephen wants to take it on then fine.
otoh given that others need to depend on this mess to get work done, I
guess I'm forced to continue to take out the garbage. Sigh.
next prev parent reply other threads:[~2008-10-09 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 10:09 [mmotm 02/Oct] fix buid error of autodetect_raid() KOSAKI Motohiro
2008-10-04 10:10 ` [mmotm 02/Oct] fix buid error of hid-core KOSAKI Motohiro
2008-10-09 6:45 ` KOSAKI Motohiro
2008-10-09 7:02 ` Andrew Morton [this message]
2008-10-09 7:15 ` KOSAKI Motohiro
2008-10-04 10:11 ` [mmotm 02/Oct] fix buid error of md raid KOSAKI Motohiro
2008-10-09 6:47 ` KOSAKI Motohiro
2008-10-04 12:10 ` [mmotm 02/Oct] fix buid error of autodetect_raid() Ingo Molnar
2008-10-04 12:18 ` KOSAKI Motohiro
2008-10-04 12:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009000208.d902be73.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.