From: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
To: Avi Kivity <avi@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] x86 emulator: Add Src2 decode set
Date: Thu, 9 Oct 2008 10:57:44 +0200 [thread overview]
Message-ID: <20081009105744.40478c77@frecb000711> (raw)
In-Reply-To: <48EDBCCD.4010705@redhat.com>
On Thu, 09 Oct 2008 10:11:57 +0200
Avi Kivity <avi@redhat.com> wrote:
> Guillaume Thouvenin wrote:
> > Instruction like shld has three operands, so we need to add a Src2
> > decode set. We start with Src2None, Src2CL, and Src2Imm8 to support
> > shld and we will expand it later.
> >
> >
>
> Please add Src2One (implied '1') as well, so we can switch the existing
> shift operators to Src2 later.
I will add Src2One but I don't understand exactly what you mean by
switching shift operators to Src2 later. I also applied other remarks,
thanks for your help. The patch follows.
next prev parent reply other threads:[~2008-10-09 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 12:52 Emulation of shld instruction doesn't work Guillaume Thouvenin
2008-10-08 13:05 ` Guillaume Thouvenin
2008-10-08 14:14 ` Avi Kivity
2008-10-09 7:52 ` [PATCH] x86 emulator: Add Src2 decode set Guillaume Thouvenin
2008-10-09 8:11 ` Avi Kivity
2008-10-09 8:24 ` Avi Kivity
2008-10-09 8:57 ` Guillaume Thouvenin [this message]
2008-10-09 9:06 ` Avi Kivity
2008-10-09 9:30 ` Guillaume Thouvenin
2008-10-09 11:23 ` [PATCH] x86 emulator: Add a Src2 decode set and SrcOne operand type Guillaume Thouvenin
2008-10-22 10:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009105744.40478c77@frecb000711 \
--to=guillaume.thouvenin@ext.bull.net \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.