From: wysochanski@sourceware.org
To: dm-cvs@sourceware.org, dm-devel@redhat.com
Subject: multipath-tools/libmultipath alias.h
Date: 9 Oct 2008 18:47:57 -0000 [thread overview]
Message-ID: <20081009184757.28704.qmail@sourceware.org> (raw)
CVSROOT: /cvs/dm
Module name: multipath-tools
Branch: RHEL4_FC5
Changes by: wysochanski@sourceware.org 2008-10-09 18:47:56
Modified files:
libmultipath : alias.h
Log message:
Fix rhbz445268: Increase bindings file lock timeout to avoid failure of user_friendly_names map
Backport from upstream.
From 29372b2edf719f30f21c610d502999fdf7d19885 Mon Sep 17 00:00:00 2001
From: Dave Wysochanski <dwysocha@redhat.com>
Date: Tue, 23 Sep 2008 13:16:38 -0400
Subject: [PATCH] Increase bindings file lock timeout to avoid failure of user_friendly_names map.
On setups with a large number of paths / multipath maps, contention for
the advisory lock on the bindings file may take longer than 3 seconds,
and some multipath processes may create maps based on WWID despite having
user_friendly_names set. Increasing the timeout is a simple fix that
gets us a bit further.
More extensive fixes might include:
1) improving the efficiency of the critical section code
2) use shared/read locks initially, then use exclusive/write locks only when
it is known the bindings file needs updated
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/multipath-tools/libmultipath/alias.h.diff?cvsroot=dm&only_with_tag=RHEL4_FC5&r1=1.1&r2=1.1.2.1
--- multipath-tools/libmultipath/alias.h 2005/11/09 22:28:58 1.1
+++ multipath-tools/libmultipath/alias.h 2008/10/09 18:47:50 1.1.2.1
@@ -1,4 +1,4 @@
-#define BINDINGS_FILE_TIMEOUT 3
+#define BINDINGS_FILE_TIMEOUT 30
#define BINDINGS_FILE_HEADER \
"# Multipath bindings, Version : 1.0\n" \
"# NOTE: this file is automatically maintained by the multipath program.\n" \
reply other threads:[~2008-10-09 18:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009184757.28704.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=dm-cvs@sourceware.org \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.