All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David John <davidjon@xenontk.org>
Cc: clemens@ladisch.de, venkatesh.pallipadi@intel.com,
	vojtech@suse.cz, bob.picco@hp.com, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] HPET: Remove spurious HPET busy warning message.
Date: Fri, 10 Oct 2008 09:26:40 +0200	[thread overview]
Message-ID: <20081010072640.GA16016@elte.hu> (raw)
In-Reply-To: <1223619164-16874-1-git-send-email-davidjon@xenontk.org>


* David John <davidjon@xenontk.org> wrote:

> On x86 systems with CONFIG_HPET_TIMER enabled, when
> the HPET driver (drivers/char/hpet.c) is loaded,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
> 
> Signed-off-by: David John <davidjon@xenontk.org>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> ---
>  drivers/char/hpet.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
>  		hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>  
>  		if (hpet_is_known(hdp)) {
> -			printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> -				__func__, hdp->hd_phys_address);
>  			iounmap(hdp->hd_address);
>  			return AE_ALREADY_EXISTS;
>  		}
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
>  						HPET_RANGE_SIZE);
>  
>  		if (hpet_is_known(hdp)) {
> -			printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> -				__func__, hdp->hd_phys_address);
>  			iounmap(hdp->hd_address);
>  			return AE_ALREADY_EXISTS;
>  		}

applied to tip/timers/hpet, thanks John!

	Ingo

       reply	other threads:[~2008-10-10  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48EEF194.5010008@xenontk.org>
     [not found] ` <1223619164-16874-1-git-send-email-davidjon@xenontk.org>
2008-10-10  7:26   ` Ingo Molnar [this message]
2008-10-06  8:52 [PATCH] HPET: Remove spurious HPET busy warning message David John
2008-10-08 19:16 ` Venki Pallipadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081010072640.GA16016@elte.hu \
    --to=mingo@elte.hu \
    --cc=bob.picco@hp.com \
    --cc=clemens@ladisch.de \
    --cc=davidjon@xenontk.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.