From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 05/12] adt7470: Add documentation
Date: Fri, 10 Oct 2008 08:25:54 +0000 [thread overview]
Message-ID: <20081010102554.0548b24e@hyperion.delvare> (raw)
In-Reply-To: <20081007011849.12701.53492.stgit@elm3a70.beaverton.ibm.com>
Hi Darrick,
On Thu, 9 Oct 2008 14:25:23 -0700, Darrick J. Wong wrote:
> On Thu, Oct 09, 2008 at 12:31:17PM +0200, Jean Delvare wrote:
>
> > Should we implement a kernel thread / tasklet / whatever it is called
> > these days that would actively read the needed temperature values (and
> > only these) every 5 seconds as soon as automatic fan speed control is
> > enabled? The current implementation seems dangerous to me, as
> > illustrated by the report you quoted above.
>
> That would work, though it'll cause wakeups even if nobody's reading the
> sensor. However, since one would generally have to run sensors-detect
> to know that it's there in the first place, I suppose anyone actually
> loading the module is doing so with the intent to monitor anyway.
My proposal is to have such a kernel thread running only when automatic
fan speed is enabled. According to the datasheet, this isn't the
default, so loading the adt7470 driver alone wouldn't start the thread.
The thread would start running only once at least one fan has been
switched to automatic mode, and would stop as soon as all fans are
switched back to manual mode.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-10-10 8:25 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 1:18 [PATCH 00/12] Various hwmon patches Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] " Darrick J. Wong
2008-10-07 1:18 ` [PATCH 01/12] hwmon: Define sysfs interface for energy consumption register Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] [PATCH 01/12] hwmon: Define sysfs interface for energy Darrick J. Wong
2008-10-08 8:09 ` [lm-sensors] [PATCH 01/12] hwmon: Define sysfs interface for energy consumption register Jean Delvare
2008-10-08 8:09 ` [lm-sensors] [PATCH 01/12] hwmon: Define sysfs interface for Jean Delvare
2008-10-07 1:18 ` [PATCH 02/12] adt7462: New hwmon driver Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] " Darrick J. Wong
2008-10-07 1:18 ` [PATCH 03/12] adt7473: Fix some bogosity in documentation file Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] [PATCH 03/12] adt7473: Fix some bogosity in Darrick J. Wong
2008-10-08 9:08 ` [lm-sensors] [PATCH 03/12] adt7473: Fix some bogosity in documentation file Jean Delvare
2008-10-08 9:08 ` [lm-sensors] [PATCH 03/12] adt7473: Fix some bogosity in Jean Delvare
2008-10-07 1:18 ` [PATCH 04/12] adt7470: Fix pwm*-auto-point* to be temp*-auto-point* Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] [PATCH 04/12] adt7470: Fix pwm*-auto-point* to be Darrick J. Wong
2008-10-08 9:25 ` [lm-sensors] [PATCH 04/12] adt7470: Fix pwm*-auto-point* to be temp*-auto-point* Jean Delvare
2008-10-08 9:25 ` [lm-sensors] [PATCH 04/12] adt7470: Fix pwm*-auto-point* to be Jean Delvare
2008-10-08 18:36 ` [lm-sensors] [PATCH 04/12] adt7470: Fix pwm*-auto-point* to Darrick J. Wong
2008-10-07 1:18 ` [PATCH 05/12] adt7470: Add documentation Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] " Darrick J. Wong
2008-10-08 9:46 ` Jean Delvare
2008-10-08 9:46 ` Jean Delvare
2008-10-08 18:50 ` Darrick J. Wong
2008-10-09 10:31 ` Jean Delvare
2008-10-09 21:25 ` Darrick J. Wong
2008-10-10 8:25 ` Jean Delvare [this message]
2008-10-07 1:18 ` [PATCH 06/12] adt7470: Load automatically on IntelliStation Z30 via DMI Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] [PATCH 06/12] adt7470: Load automatically on Darrick J. Wong
2008-10-08 11:08 ` [lm-sensors] [PATCH 06/12] adt7470: Load automatically on IntelliStation Z30 via DMI Jean Delvare
2008-10-08 11:08 ` [lm-sensors] [PATCH 06/12] adt7470: Load automatically on Jean Delvare
2008-10-07 1:18 ` [PATCH 07/12] ics932s401: New driver Darrick J. Wong
2008-10-07 1:18 ` [lm-sensors] " Darrick J. Wong
2008-10-08 11:09 ` Jean Delvare
2008-10-08 11:09 ` Jean Delvare
2008-10-08 18:26 ` Darrick J. Wong
2008-10-09 11:37 ` Jean Delvare
2008-10-07 1:19 ` [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets Darrick J. Wong
2008-10-07 1:19 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all Darrick J. Wong
2008-10-08 11:13 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets Jean Delvare
2008-10-08 11:13 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all Jean Delvare
2008-10-08 18:19 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on Darrick J. Wong
2008-10-09 11:43 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all Jean Delvare
2008-10-10 17:54 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on Darrick J. Wong
2008-10-15 8:48 ` [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all Jean Delvare
2008-10-07 1:19 ` [PATCH 09/12] ibmpex: Automatically load on IBM systems via DMI Darrick J. Wong
2008-10-07 1:19 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM Darrick J. Wong
2008-10-08 12:01 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM systems via DMI Jean Delvare
2008-10-08 12:01 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM Jean Delvare
2008-10-08 14:33 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM systems via DMI Christian Krafft
2008-10-08 14:33 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM Christian Krafft
2008-10-08 18:09 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on Darrick J. Wong
2008-10-09 11:47 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM Jean Delvare
2008-10-09 17:21 ` [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on Darrick J. Wong
2008-10-07 1:19 ` [PATCH 10/12] ibmaem: Automatically load on IBM systems via DMI Darrick J. Wong
2008-10-07 1:19 ` [lm-sensors] [PATCH 10/12] ibmaem: Automatically load on IBM Darrick J. Wong
2008-10-07 1:19 ` [PATCH 11/12] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-10-07 1:19 ` [lm-sensors] [PATCH 11/12] adt7470: Check input range when sysfs Darrick J. Wong
2008-10-09 9:09 ` [lm-sensors] [PATCH 11/12] adt7470: Check input range when Jean Delvare
2008-10-07 1:19 ` [PATCH 12/12] adt7473: Check inputs from sysfs writes Darrick J. Wong
2008-10-07 1:19 ` [lm-sensors] " Darrick J. Wong
2008-10-07 1:27 ` [PATCH 00/12] Various hwmon patches Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010102554.0548b24e@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.