From: David Brownell <david-b@pacbell.net>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 4/7] Hook twl4030 power code into twl4030 core.
Date: Fri, 10 Oct 2008 10:57:01 -0700 [thread overview]
Message-ID: <200810101057.01845.david-b@pacbell.net> (raw)
In-Reply-To: <1223657776-16544-5-git-send-email-peter.de-schrijver@nokia.com>
On Friday 10 October 2008, Peter 'p2' De Schrijver wrote:
> +#ifdef CONFIG_TWL4030_POWER
Nothing in your patches seems to set that... or update
the Makefile so that this file gets linked.
Wouldn't it be simpler to just not have that #ifdef,
and always link it? If there's no script to install,
no problem; I'll not worry about some __init code.
- Dave
next prev parent reply other threads:[~2008-10-10 17:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 16:56 [PATCH 0/7] Integrate the twl4030 power code into new twl4030 mfd Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 1/7] Remove existing twl4030 power script code Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 2/7] Add defines and data types for twl4030 Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 3/7] Twl4030 power code updated for new twl4030 core Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 4/7] Hook twl4030 power code into " Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 5/7] 3430sdp and ldp use custom twl4030 power scripts Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 6/7] Generic twl4030 power script for 3430 based boards Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script Peter 'p2' De Schrijver
2008-10-10 17:50 ` David Brownell
2008-10-13 8:23 ` Peter 'p2' De Schrijver
2008-10-14 16:26 ` David Brownell
2008-10-10 17:53 ` [PATCH 5/7] 3430sdp and ldp use custom twl4030 power scripts David Brownell
2008-10-13 8:45 ` Peter 'p2' De Schrijver
2008-10-14 16:28 ` David Brownell
2008-10-10 17:57 ` David Brownell [this message]
2008-10-11 18:50 ` [PATCH 4/7] Hook twl4030 power code into twl4030 core Felipe Balbi
2008-10-20 22:27 ` Samuel Ortiz
2008-10-11 18:49 ` [PATCH 3/7] Twl4030 power code updated for new " Felipe Balbi
2008-10-11 18:46 ` [PATCH 2/7] Add defines and data types for twl4030 Felipe Balbi
2008-10-11 18:45 ` [PATCH 1/7] Remove existing twl4030 power script code Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-10-13 15:44 [PATCH 0/7] Integrate the twl4030 power code into new twl4030 mfd Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 1/7] Remove existing twl4030 power script code Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 2/7] Add defines and data types for twl4030 Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 3/7] Twl4030 power code updated for new twl4030 core Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 4/7] Hook twl4030 power code into " Peter 'p2' De Schrijver
2008-10-14 17:42 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810101057.01845.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.